build: move addons message in Makefile#23114
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Displaying a message about building addons before building docs can be confusing when troubleshooting. (This just happened to me.) Move the message about building addons to just before the step for building addons.
nodejs-github-bot
added
the
build
Member
Author
danbev
approved these changes
Sep 27, 2018
targos
approved these changes
Sep 27, 2018
cjihrig
approved these changes
Sep 27, 2018
Member
Author
|
CI rebuilds: Linux: https://ci.nodejs.org/job/node-test-commit-linux/21895/ ✔️ |
addaleax
approved these changes
Sep 27, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM but tbh, I never really understood what the messages was actually supposed to tell me.
Trott
added
the
author ready
thefourtheye
approved these changes
Sep 27, 2018
Member
Author
|
Can't do a rebuild on ARM fanned because they've been taken offline for infra issues. Kicking of a node-test-commit won't run ARM fanned at this time. So I'm effectively treating the CI as all good now. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 27, 2018
Displaying a message about building addons before building docs can be confusing when troubleshooting. (This just happened to me.) Move the message about building addons to just before the step for building addons. PR-URL: nodejs#23114 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Member
Author
|
Landed in c9c4550 |
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
Displaying a message about building addons before building docs can be confusing when troubleshooting. (This just happened to me.) Move the message about building addons to just before the step for building addons. PR-URL: #23114 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
3 tasks
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
Displaying a message about building addons before building docs can be confusing when troubleshooting. (This just happened to me.) Move the message about building addons to just before the step for building addons. PR-URL: #23114 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displaying a message about building addons before building docs can be
confusing when troubleshooting. (This just happened to me.) Move the
message about building addons to just before the step for building
addons.
👍 here to fast-track.
@nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes