Skip to content

src: name EmbededderGraph edges and use class names for nodes #23072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

src: name EmbededderGraph edges and use class names for nodes #23072

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e18aafa
src: name EmbededderGraph edges and use class names for nodes
joyeecheung Sep 23, 2018
cd07235
fixup! src: name EmbededderGraph edges and use class names for nodes
joyeecheung Sep 26, 2018
774ae11
fixup! src: name EmbededderGraph edges and use class names for nodes
joyeecheung Oct 3, 2018
e56d4c0
fixup! src: name EmbededderGraph edges and use class names for nodes
joyeecheung Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src: name EmbededderGraph edges and use class names for nodes
  • Loading branch information
@joyeecheung
joyeecheung committed Oct 3, 2018
commit 774ae1144ae0ebe2657df8300a395283667c3f94
22 changes: 11 additions & 11 deletions src/memory_tracker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,16 @@ class NodeBIO;
* void MemoryInfo(MemoryTracker* tracker) const override {
* // Node name and size comes from the MemoryInfoName and SelfSize of
* // AnotherRetainerClass
* tracker->TrackField("another_retainer", another_retainer);
* tracker->TrackField("another_retainer", another_retainer_);
* // Specify node name and size explicitly
* tracker->TrackFieldWithSize("internal_member",
* internal_member.size(),
* internal_member_.size(),
* "InternalClass");
* // Node name falls back to the edge name,
* // elements in the container appear as grandchildren nodes
* tracker->TrackField("vector", vector);
* tracker->TrackField("vector", vector_);
* // Node name and size come from the JS object
* tracker->TrackField("target", target);
* tracker->TrackField("target", target_);
* }
*
* // Or use SET_MEMORY_INFO_NAME(ExampleRetainer)
Expand All @@ -67,17 +67,17 @@ class NodeBIO;
*
* // Note: no need to implement these two methods when implementing
* // a BaseObject or an AsyncWrap class
* bool IsRootNode() const override { return !wrapped.IsWeak(); }
* bool IsRootNode() const override { return !wrapped_.IsWeak(); }
* v8::Local<v8::Object> WrappedObject() const override {
* return node::PersistentToLocal(wrapped);
* return node::PersistentToLocal(wrapped_);
* }
* private:
* AnotherRetainerClass another_retainer;
* InternalClass internal_member;
* std::vector<uv_async_t> vector;
* node::Persistent<Object> target;
* AnotherRetainerClass another_retainer_;
* InternalClass internal_member_;
* std::vector<uv_async_t> vector_;
* node::Persistent<Object> target_;
*
* node::Persistent<Object> wrapped;
* node::Persistent<Object> wrapped_;
* }
*
* This creates the following graph:
Expand Down