Skip to content

[v10.x backport] tools, test: forbid string literal as third argument for assert.strictEqual() and friends #22912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 12 commits into from
Closed

[v10.x backport] tools, test: forbid string literal as third argument for assert.strictEqual() and friends #22912

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8b69c00
test: remove string literal message from assertion
Trott Sep 13, 2018
9579f7a
test: remove string literal message in assertions
Trott Sep 13, 2018
efe0d17
test: improve assertion in test-inspector.js
Trott Sep 2, 2018
d1c0f51
test: simplify assertion in http2 tests
Trott Sep 2, 2018
c924e16
test: refactor flag check
Trott Sep 13, 2018
bc9ae8e
test: remove string literal from assertion
Trott Sep 13, 2018
8e4fc42
test: remove string literal message from assertion
Trott Sep 13, 2018
495bb6d
test: remove string literal arg from assertion
Trott Sep 13, 2018
1db83a7
test: remove string literal from assertion
Trott Sep 13, 2018
b423af6
test: remove string literal from assertion
Trott Sep 13, 2018
dcf4a35
test: prepare test-assert for strictEqual linting
Trott Sep 13, 2018
f6f5920
tools: prevent string literals in some assertions
Trott Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: prepare test-assert for strictEqual linting 
Make minor modifications to test-assert.js to prepare it for linting
rule that forbids the use of string literals for the third argument of
assert.strictEqual().

PR-URL: #22849
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
@Trott
Trott committed Sep 17, 2018
commit dcf4a35c7f576f9f2d2cdce5c25ca77e79cb7c4a
6 changes: 3 additions & 3 deletions test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,11 @@ try {
}

try {
assert.strictEqual(1, 2, 'oh no');
assert.strictEqual(1, 2, 'oh no'); // eslint-disable-line no-restricted-syntax
} catch (e) {
assert.strictEqual(e.message, 'oh no');
assert.strictEqual(e.generatedMessage, false,
'Message incorrectly marked as generated');
// Message should not be marked as generated.
assert.strictEqual(e.generatedMessage, false);
}

{
Expand Down