Conversation
common.fileExists() can be replaced with fs.existsSync().
fesebuv
left a comment
There was a problem hiding this comment.
Seems good to me, but I would advice to double check why some tests are failing.
|
https://ci.nodejs.org/job/node-test-commit-custom-suites/458/default/console failed because of stale processes. Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16225/ |
|
Line 36 in a4c1cf5 |
|
CI with @targos's comment addressed: https://ci.nodejs.org/job/node-test-pull-request/16231/ |
common.fileExists() can be replaced with fs.existsSync(). PR-URL: nodejs#22151 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
|
Landed in 41ae423 |
|
Strangely, we have CI fails now due to this test: See #22104 (comment) |
That test was added to the codebase in between the last CI for this PR (2 days ago) and it landing today. |
test-trace-event-promises.js was added to the codebase between the last CI for nodejs#22151 and it landing. Refs: nodejs#22151
|
Fix for the additional test: #22200 |
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
|
Oops! Add this to the list of reasons to get https://github.com/nodejs/commit-queue happening. @nodejs/commit-queue |
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
common.fileExists() can be replaced with fs.existsSync(). PR-URL: #22151 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
|
|
test-trace-event-promises.js was added to the codebase between the last CI for nodejs/node#22151 and it landing. PR-URL: nodejs/node#22200 Refs: nodejs/node#22151 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
common.fileExists() can be replaced with fs.existsSync(). PR-URL: nodejs/node#22151 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
common.fileExists() can be replaced with fs.existsSync().
fs.existsSync()was undeprecated in Node.js 6.8.0.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes