Skip to content

test: update setTimeout on file test/internet/test-net-connect-unref.js to use common.platformTimeout #21969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
conectado wants to merge 3 commits into from
Closed

test: update setTimeout on file test/internet/test-net-connect-unref.js to use common.platformTimeout #21969

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef9b217
test: update setTimeout to use common.platformTimeout
conectado Jul 25, 2018
dbfffbf
test: remove setTimeout from the file
conectado Jul 25, 2018
548e70b
test: remove unused TIMEOUT variable
conectado Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: update setTimeout to use common.platformTimeout 
Changes the time used by the last line of the file to normalize the timeout
by using the common library.
  • Loading branch information
@conectado
conectado committed Jul 25, 2018
commit ef9b21777e900e0b9fc1eb36a2fbf7139d2eb33d
2 changes: 1 addition & 1 deletion test/internet/test-net-connect-unref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ const client = net.createConnection(53, '8.8.8.8', function() {

client.on('close', common.mustNotCall());

setTimeout(common.mustNotCall(), TIMEOUT).unref();
setTimeout(common.mustNotCall(), common.platformTimeout(TIMEOUT)).unref();