Skip to content

fs: reduce memory retention when streaming small files #21968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

fs: reduce memory retention when streaming small files #21968

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d39c4ba
fs: reduce memory retention when streaming small files
addaleax Jul 25, 2018
c7b4737
[squash] fix linter
addaleax Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] fix linter
  • Loading branch information
@addaleax
addaleax committed Jul 25, 2018
commit c7b4737539d1f92fa158b9d09e41e4777f7d0660
2 changes: 1 addition & 1 deletion test/parallel/test-fs-read-stream-concurrent-reads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function startRead() {
assert.deepStrictEqual(Buffer.concat(chunks), content);
if (++done === N) {
const retainedMemory =
[...arrayBuffers].map(buf => buf.byteLength).reduce((a, b) => a + b);
[...arrayBuffers].map((ab) => ab.byteLength).reduce((a, b) => a + b);
assert(retainedMemory / (N * content.length) <= 3,
`Retaining ${retainedMemory} bytes in ABs for ${N} ` +
`chunks of size ${content.length}`);
Expand Down