test: allow tests to pass without internet#21909
test: allow tests to pass without internet#21909helio-frota wants to merge 1 commit intonodejs:masterfrom helio-frota:internet-tests
Conversation
|
Please thumbs up here if you are OK with fast tracking this and i will land it. |
It's probably a good idea to run the |
Internet run: https://ci.nodejs.org/job/node-test-commit-custom-suites/138/ |
|
@Trott thanks for running those. I poked around CI when @richardlau mentioned running just one suite, and doing that was non-obvious. After consulting the collaborator guide it was still non-obvious. I know that due to my intermittent presence here, things can change. Is there any place this test suite is documented? After taking a look at the build job parameters it seems pretty straightforward. But, tbqh, I really didn't have any idea what to do when @richardlau mentioned it above. |
|
Landed in 2058a1c |
PR-URL: #21909 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #21909 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: nodejs#21909 (comment)
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: nodejs#21909 (comment) PR-URL: nodejs#21927 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: #21909 (comment) PR-URL: #21927 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
8 participants
Currently when running the test without an internet connection the following error appears:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes