Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
be2a467
doc: fix incorrect fs.readFileSync example output
not-an-aardvark May 22, 2018
ed84b7d
test: changed assert message from string literal to template literal
CoreyGMartin May 21, 2018
443d60a
test: use log only in test-child-process-fork-net
Trott May 21, 2018
ed9e964
net: remove unnecessary variables
chainhelen May 21, 2018
ea702e2
assert: handle undefined filename in getErrMessage
jeysal May 20, 2018
b0023d7
src,doc: add doc of --prof flag to help command
ohbarye May 20, 2018
554ad47
test: improve coverage for readline.Interface
May 13, 2018
099c6b6
meta: add link to unofficial discord
devsnek May 4, 2018
819bba6
doc: removed LTS label from v4 in doc version picker
May 23, 2018
ba30d14
n-api: throw when entry point is null
May 16, 2018
d2bcd55
lib: remove unnecessary string interpolation
danbev May 22, 2018
b242248
net: allow IPC servers be accessible by all
bzoz Mar 7, 2018
1f3eb1c
doc: fix filehandle.truncate() sample codes
May 23, 2018
d0cdcb6
deps: upgrade npm to 6.1.0
iarna Apr 21, 2018
9bbab91
test: include port in assertion message
May 22, 2018
45adec2
module: name anonymous function for debugging
ndangles May 18, 2018
b4519ca
src: move DeleteFnPtr into util.h
addaleax May 21, 2018
c036cda
doc: fix outdated link FSEvents
amitbend May 24, 2018
87ad931
doc: update the notable changes
BridgeAR Apr 26, 2018
40e5788
test: remove string literal from strictEqual
AbhimanyuVashisht May 24, 2018
82afb4c
test: remove message argument from strictEqual()
sagirk May 23, 2018
418739c
src: fix MallocedBuffer move assignment operator
addaleax May 13, 2018
efc7f91
deps: cherry-pick 6989b3f6d7 from V8 upstream
TimothyGu May 18, 2018
460add9
test: reduce runtime
BridgeAR May 12, 2018
d09bec8
test: improve error message in async-wrap test
Trott May 24, 2018
bfe6dc3
fs: fix reads with pos > 4GB
mafintosh May 28, 2018
5e69e1a
src: add CHECK_IMPLIES macro
tniessen May 20, 2018
902120a
src: add CHECK_NULL/CHECK_NOT_NULL macros
tniessen May 20, 2018
f0704f2
doc: mark Node 4 as EOL in changelog
not-an-aardvark May 24, 2018
46e7cec
tools: fix sorting in doc/type-parser.js
vsemozhetbyt May 26, 2018
d7fed22
build,win: disable DLL-interface warnings
piscisaureus May 25, 2018
c2c3b6f
lib: use object destructuring for ContextifyScript
danbev May 24, 2018
babc9da
doc: add jdalton to collaborators
jdalton May 25, 2018
460a502
test: fix test failure on aix
BridgeAR May 24, 2018
88f9a39
test: isolate unusual assert test in its own file
Trott May 21, 2018
0112357
test: improve assert test hygiene
Trott May 21, 2018
ce13797
doc: fix doc for napi_get_typedarray_info
mhdawson May 15, 2018
5f9c01b
Revert "repl: add friendly tips about how to exit repl"
cjihrig May 26, 2018
8f52c3f
stream: fix removeAllListeners() for Stream.Readable
kaelzhang May 24, 2018
b62cbe1
tools: update tools/doc/package-lock.json
Trott May 25, 2018
c1dae43
2018-05-29, Version 10.3.0 (Current)
MylesBorins May 29, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: improve error message in async-wrap test
Improve AssertionError message in
test/parallel/test-async-wrap-pop-id-during-load.js to include the
contents of stderr when the spawned process fails.

Refs: https://github.com/nodejs/node/pull/20940/files#r190707951

PR-URL: #20948
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
Trott authored and MylesBorins committed May 29, 2018
commit d09bec8a047b99d1b7428431d6f5de9be20ba8ee
3 changes: 2 additions & 1 deletion test/parallel/test-async-wrap-pop-id-during-load.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ const ret = spawnSync(
process.execPath,
['--stack_size=50', __filename, 'async']
);
assert.strictEqual(ret.status, 0);
assert.strictEqual(ret.status, 0,
`EXIT CODE: ${ret.status}, STDERR:\n${ret.stderr}`);
const stderr = ret.stderr.toString('utf8', 0, 2048);
assert.ok(!/async.*hook/i.test(stderr));
assert.ok(stderr.includes('UnhandledPromiseRejectionWarning: Error'), stderr);