Skip to content

src: do not cache NumberOfHeapSpaces() globally #20971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

src: do not cache NumberOfHeapSpaces() globally #20971

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0df7dec
src: do not cache `NumberOfHeapSpaces()` globally
addaleax May 25, 2018
f26c89c
[squash] bnoordhuis suggestion
addaleax May 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] bnoordhuis suggestion
  • Loading branch information
@addaleax
addaleax authored May 26, 2018
commit f26c89ca5055313f62c10ff52dc35908936eaae2
3 changes: 2 additions & 1 deletion src/node_v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ void UpdateHeapSpaceStatisticsBuffer(const FunctionCallbackInfo<Value>& args) {
HeapSpaceStatistics s;
Isolate* const isolate = env->isolate();
double* buffer = env->heap_space_statistics_buffer();
size_t number_of_heap_spaces = env->isolate()->NumberOfHeapSpaces();

for (size_t i = 0; i < isolate->NumberOfHeapSpaces(); i++) {
for (size_t i = 0; i < number_of_heap_spaces; i++) {
isolate->GetHeapSpaceStatistics(&s, i);
size_t const property_offset = i * kHeapSpaceStatisticsPropertiesCount;
#define V(index, name, _) buffer[property_offset + index] = \
Expand Down