doc: add jdalton to collaborators#20968
doc: add jdalton to collaborators#20968jdalton wants to merge 1 commit intonodejs:masterfrom jdalton:jdd
Conversation
|
Welcome :-) |
jdalton
changed the title
|
Thank you! (I currently still need the bits toggled to be able to spin up a CI run and-or merge). |
README.md
Outdated
There was a problem hiding this comment.
The lines seem to be in the wrong order) Screenshot:
vsemozhetbyt
added
meta
|
@jdalton Are you being onboarded by somebody at the moment? We usually open these PRs as part of that process – not that there’s anything wrong with this PR, but I think we want to wait with merging it until that occurs? |
addaleax
removed
the
fast-track
|
@addaleax I thought these PRs are always meant to be merged by the onboarded person. If there was no onboarding, that is of course not happening. |
That's cool. No one has contacted me yet for onboarding (so I figured I'd get the ball rolling). |
|
I'm going to set blocked just to prevent anyone else merging (although by convention these PRs should only be merged by the onboarded person anyway). Obviously consider it unblocked when the onboarding occurs. |
|
Landed in bb6b605 |
PR-URL: nodejs#20968 Fixes: nodejs#20828 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
|
post-closure LGTM! |
|
Welcome aboard @jdalton ! |
PR-URL: #20968 Fixes: #20828 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
16 participants
Fixes: #20828
Checklist