Skip to content

[v10.x] src: more automatic memory management in node_crypto.cc #20609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 81 commits into from
Closed

[v10.x] src: more automatic memory management in node_crypto.cc #20609

Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
763627a
doc: add more missing backticks
vsemozhetbyt Apr 29, 2018
f6c6950
doc: remove squash guideline from onboarding doc
Trott Apr 30, 2018
ca7e3e4
doc: add squash guideline to pull-requests doc
Trott Apr 30, 2018
8fbd0d3
benchmark: fix next-tick-depth
apapirovski May 2, 2018
a8fc842
doc: add http.ClientRequest maxHeadersCount
darai0512 Apr 23, 2018
f6d37f2
tools: fix TypeError from `test.py --time`
richardlau Apr 27, 2018
bd8e626
doc: update writing-and-running-benchmarks.md
xsbchen Apr 28, 2018
a8ffbbe
timers: named anonymous functions
js-kyle Apr 29, 2018
147ced4
child_process: name anonymous functions
SerayaEryn Apr 29, 2018
3d2a7fe
test: remove unnecessary strictEqual() argument from remoteClose()
dayloryanes Apr 26, 2018
f438438
test: use fs.copyFileSync()
richardlau Apr 26, 2018
1de252a
doc: add missing periods in documentation.md
vsemozhetbyt May 2, 2018
52e6ef0
events: optimize condition for optimal scenario
apapirovski May 1, 2018
dbf3089
util: improve spliceOne perf
apapirovski May 1, 2018
2d26f55
doc: update cli flag in crypto.md
shobhitchittora Apr 29, 2018
b15c793
doc: synchronize argument names for appendFile()
Trott May 3, 2018
43ba7a6
util: named anonymous functions
ccoxwell Apr 29, 2018
81584d1
lib: named anonymous functions
ccoxwell Apr 30, 2018
7e87142
doc: update Collaborator Guide reference
Trott May 2, 2018
36d93da
doc: cleanup n-api.md doc
mhdawson Apr 30, 2018
a5467bf
src: remove `kFlagNoShutdown` flag
addaleax Apr 28, 2018
fd67e9e
src: access `ContextifyContext*` more directly in property cbs
addaleax May 1, 2018
98a39e3
src: refactor `BaseObject` internal field management
addaleax May 1, 2018
18bb358
doc: update examples for fs.access()
BeniCheni May 1, 2018
d329778
n-api: make test_error functions static
Apr 27, 2018
c66ba19
crypto: allocate more memory for cipher.update()
yhwang Apr 26, 2018
ff148b9
deps: patch V8 to 6.6.346.27
MylesBorins May 2, 2018
8c0cf1e
doc: fix mkdtemp() documentation
Trott May 4, 2018
0254698
doc: document using `domain` in REPL
AyushG3112 Apr 28, 2018
d7dcc0a
test: add fs/promises filehandle stat test
May 3, 2018
064b061
repl: add spaces to load/save messages
cjihrig May 5, 2018
5248cd7
test: rename misnamed test
Trott May 5, 2018
6966c04
test: fix up N-API error test
May 3, 2018
ae33fa3
src: fix inconsistency in extern declaration
hashseed Apr 30, 2018
3da63ff
build: check for different deprecation signatures
BridgeAR Apr 28, 2018
34f73ec
doc: fix manpage warning
kapouer Apr 28, 2018
b9dfaac
https: defines maxHeadersCount in the constructor
darai0512 Apr 22, 2018
1e2ce1d
src: removed unnecessary prototypes from Environment::SetProtoMethod
brandontruggles Apr 26, 2018
0642b6f
test: fix common.canCreateSymLink() on non-Windows
May 4, 2018
f508574
lib: expose FixedQueue internally and fix nextTick bug
apapirovski May 2, 2018
fc311f2
tls: cleanup onhandshakestart callback
apapirovski May 2, 2018
d0d0547
benchmark: track exec time in next-tick-exec
apapirovski May 2, 2018
0f75c08
doc: fix N-API property descriptor documentation
Apr 30, 2018
31dfb0a
doc: updates crypto doc with openssl list -cipher-algorithms
shobhitchittora May 3, 2018
d866984
tls: remove sharedCreds in Server constructor
danbev May 3, 2018
6e2a22f
errors: remove dead code
BridgeAR May 2, 2018
755e88f
http2: rename http2_state class to Http2State
danbev Apr 30, 2018
59ed6c0
doc: add snake_case section for C-like structs
danbev May 2, 2018
ea6af3b
src: add public API to expose the main V8 Platform
helloshuangzi May 1, 2018
aef4f80
doc: update one more command in crypto.md
shobhitchittora May 3, 2018
c06821a
Revert "stream: prevent 'end' to be emitted after 'error'"
mscdex May 1, 2018
b06d90d
url: fix WHATWG host formatting error
peakji May 3, 2018
a068808
tools: remove redundant code in doc/html.js
vsemozhetbyt May 4, 2018
883d03b
doc: clearer doc-only deprecations
BridgeAR Apr 28, 2018
702ba74
test: fix buffer writes on mips
BridgeAR Apr 27, 2018
849d10d
test: fix test-cli-node-options.js on mips
BridgeAR Apr 28, 2018
f8ddf7b
doc: add parameters for Http2Session:stream event
ryzokuken May 5, 2018
2bddd24
doc: edit text for DEP0104
Trott May 4, 2018
b7e8249
doc: edit text for DEP0101
Trott May 4, 2018
6011c21
doc: edit text for DEP0012
Trott May 4, 2018
6a18a42
doc: edit text for DEP0094
Trott May 4, 2018
7d9234b
doc: fix text for DEP0085
Trott May 4, 2018
bc8d08d
doc: edit text for DEP0082
Trott May 4, 2018
f59619a
doc: fix minor typographical error in DEP0079 text
Trott May 4, 2018
17f9da5
doc: minor edit to DEP0065
Trott May 4, 2018
4ce7026
doc: edit text for DEP0013
Trott May 4, 2018
b0d6edc
doc: edit text about revoking deprecations
Trott May 4, 2018
dc8c8ef
doc: excise "periodically" before "emit events"
jeswcollins May 7, 2018
9ba8ab0
doc: update "Who to cc..." in COLLABORATOR_GUIDE
vsemozhetbyt May 6, 2018
8ed803d
fs: move fs/promises to fs.promises
cjihrig May 3, 2018
381fccd
doc: add trace category for fs sync methods
chinhuang007 May 4, 2018
fa0565e
console: make console.table() use colored inspect
makenowjust May 4, 2018
e2fb920
doc: move tunniclm to Emeritus
Trott May 5, 2018
acf3019
fs: remove broken code in promises/write
ChALkeR Apr 29, 2018
88f9c38
fs: fchmod->fchown in promises/lchown
ChALkeR Apr 29, 2018
69a8a65
doc: clarify `this` in event listeners
dagolinuxoid May 5, 2018
7b4e815
tools: add v10 to alternative version docs menu
vsemozhetbyt May 7, 2018
85babad
test: use common.canCreateSymLink() consistently
cjihrig May 5, 2018
aad2c23
tools: add eslint check for skipIfEslintMissing
richardlau Apr 27, 2018
7bf23cf
doc: match console.count()/countReset() signatures
Lambdac0re May 8, 2018
c7514a5
src: more automatic memory management in node_crypto.cc
addaleax Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
child_process: name anonymous functions 
Refs: #8913

PR-URL: #20399
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
@SerayaEryn @MylesBorins
SerayaEryn authored and MylesBorins committed May 4, 2018
commit 147ced42e787d8a3d85b17e61336f1c36d77a2f0
10 changes: 5 additions & 5 deletions lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function stdioStringToArray(option) {
}
}

exports.fork = function(modulePath /* , args, options */) {
exports.fork = function fork(modulePath /* , args, options */) {

// Get options and args arguments.
var execArgv;
Expand Down Expand Up @@ -110,7 +110,7 @@ exports.fork = function(modulePath /* , args, options */) {
};


exports._forkChild = function(fd) {
exports._forkChild = function _forkChild(fd) {
// set process.send()
var p = new Pipe(PipeConstants.IPC);
p.open(fd);
Expand Down Expand Up @@ -143,7 +143,7 @@ function normalizeExecArgs(command, options, callback) {
}


exports.exec = function(command /* , options, callback */) {
exports.exec = function exec(command /* , options, callback */) {
var opts = normalizeExecArgs.apply(null, arguments);
return exports.execFile(opts.file,
opts.options,
Expand Down Expand Up @@ -172,7 +172,7 @@ Object.defineProperty(exports.exec, util.promisify.custom, {
value: customPromiseExecFunction(exports.exec)
});

exports.execFile = function(file /* , args, options, callback */) {
exports.execFile = function execFile(file /* , args, options, callback */) {
var args = [];
var callback;
var options = {
Expand Down Expand Up @@ -511,7 +511,7 @@ function normalizeSpawnArguments(file, args, options) {
}


var spawn = exports.spawn = function(/* file, args, options */) {
var spawn = exports.spawn = function spawn(/* file, args, options */) {
var opts = normalizeSpawnArguments.apply(null, arguments);
var options = opts.options;
var child = new ChildProcess();
Expand Down