Skip to content

inspector: migrate node to js_protocol.pdl #20141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexkozy wants to merge 1 commit into from
Closed

inspector: migrate node to js_protocol.pdl #20141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
inspector: migrate node to js_protocol.pdl 
On inspector side we are going to deprecate .json protocol
definition formation and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.
  • Loading branch information
@alexkozy
alexkozy committed Apr 19, 2018
commit 099df7398d42375c4dc7453c9da7fe74fbaca65d
23 changes: 22 additions & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,11 +681,32 @@
'conditions': [
[ 'v8_enable_inspector==1', {
'actions': [
{
'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder',
'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ],
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ],
'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ],
},
{
'action_name': 'v8_inspector_convert_protocol_to_json',
'inputs': [
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
],
'action': [
'python',
'deps/v8/third_party/inspector_protocol/ConvertProtocolToJSON.py',
'<@(_inputs)',
'<@(_outputs)',
],
},
{
'action_name': 'v8_inspector_compress_protocol_json',
'process_outputs_as_sources': 1,
'inputs': [
'deps/v8/src/inspector/js_protocol.json',
'<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/v8_inspector_protocol_json.h',
Expand Down