Conversation
refack
requested review from
MylesBorins,
Trott,
joyeecheung,
targos,
vsemozhetbyt and
watilde
nodejs-github-bot
added
build
There was a problem hiding this comment.
Nit: missing line break at EOF.
tools/remark-cli/LICENSE
Outdated
|
This sounds like a great solution to the problem. If it works we should probably consider doing the same for eslint. |
There was a problem hiding this comment.
The lint-md-build makefile target is removed, can you add it back with a command that runs this?
There was a problem hiding this comment.
Since our CI runs this for every lint, I've made make lint-md-build a no-op, and added make lint-md-rollup
|
Very nice work. Thank you for working on this! |
|
This is marked as WIP @refack is there anything else to do to get this landed (besides open comments)? |
I was hoping for some feedback on how we should track the license, and document this. Also i'm not sure how to test the new script... |
|
@refack I think writing a bad .md in the root directory then running |
|
Ping @refack |
|
I guess it is a good idea to do this but I am going to close this due to no response. If anyone feels like taking a stab at this, that would be great. @refack please reopen in case you want to continue working on this. |
Also |
PR-URL: nodejs#20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
* remove unused `tools/remark-cli` * vcbuild tested with `vcbuild nobuild noprojgen lint-md-build lint-md` PR-URL: nodejs#20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
refack
force-pushed
the
rolled-up-lint-md
branch
from
67b6082 to
e4dd213
Compare
PR-URL: #20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
* remove unused `tools/remark-cli` * vcbuild tested with `vcbuild nobuild noprojgen lint-md-build lint-md` PR-URL: #20109 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
- In release guide - In Travis config Refs: nodejs#20109
- In release guide - In Travis config Refs: #20109 PR-URL: #22991 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
- In release guide - In Travis config Refs: #20109 PR-URL: #22991 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
- In release guide - In Travis config Refs: #20109 PR-URL: #22991 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
- In release guide - In Travis config Refs: #20109 PR-URL: #22991 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
9 participants
replace
remark-cliandremark-preset-lint-nodewith a "rolled-up" single file.Makefileissue/CC @wooorm @nodejs/build
H/T: @rollup
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes