Skip to content

build, tools, win: enable build without nasm #19930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shigeki wants to merge 1 commit into from
Closed

build, tools, win: enable build without nasm #19930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build, tools, win: enable build without nasm 
Do not terminate vcbuild.bat even if nasm is not found on Windows.
In that case, configure emits a warning message and continues to build
Node.js with openssl_no_asm option enabled.
  • Loading branch information
@shigeki
shigeki committed Apr 11, 2018
commit b5acbcf7166fff0c69fffcc33c62a6199ced9e23
2 changes: 1 addition & 1 deletion tools/msvs/find_nasm.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ IF EXIST "%ProgramFiles(x86)%\NASM\nasm.exe" (
EXIT /B 0
)

EXIT /B 1
EXIT /B 0
1 change: 0 additions & 1 deletion vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ call tools\msvs\find_python.cmd
if errorlevel 1 goto :exit

call tools\msvs\find_nasm.cmd
if errorlevel 1 echo Could not find NASM, it will not be used.

call :getnodeversion || exit /b 1

Expand Down