Skip to content

assert: use a default message in assert #18319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

assert: use a default message in assert #18319

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc44f2
assert: use a default message in assert
BridgeAR Jan 23, 2018
8f8a69c
fixup: improve test case
BridgeAR Jan 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: improve test case
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 29, 2018
commit 8f8a69c22479c59baa4e30abaa0bedc2a998a9c6
2 changes: 1 addition & 1 deletion test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ common.expectsError(
assert.equal(Object.keys(assert).length, Object.keys(a).length);
assert(7);
assert.throws(
() => assert(),
() => assert(...[]),
{
message: 'No value argument passed to `assert.ok()`',
name: 'AssertionError [ERR_ASSERTION]'
Expand Down