Skip to content

Fix compiler warnings #18205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 2 commits into from
Closed

Fix compiler warnings #18205

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7755f95
src: fix -Wunused-but-set-variable warnings
bnoordhuis Jan 17, 2018
41ba980
src: fix -Wimplicit-fallthrough warning
bnoordhuis Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: fix -Wimplicit-fallthrough warning
  • Loading branch information
@bnoordhuis
bnoordhuis committed Jan 17, 2018
commit 41ba980dc7f019a2d3e11a9969cef6a1eeca898d
3 changes: 2 additions & 1 deletion src/node_i18n.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,8 @@ static int GetColumnWidth(UChar32 codepoint,
if (ambiguous_as_full_width) {
return 2;
}
// Fall through if ambiguous_as_full_width if false.
// If ambiguous_as_full_width is false:
// Fall through
Copy link
Member

@jasnell jasnell Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Member Author

@bnoordhuis bnoordhuis Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's the second commit. // Fall through is a magic comment that gcc recognizes.

Copy link
Member

@jasnell jasnell Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.... I don't think I ever knew that... good to know :-)

case U_EA_NEUTRAL:
if (u_hasBinaryProperty(codepoint, UCHAR_EMOJI_PRESENTATION)) {
return 2;
Expand Down