test: adding Countdown to test-http-set-cookies test#17504
Closed
shilomagen wants to merge 4 commits intonodejs:masterfrom
Closed
test: adding Countdown to test-http-set-cookies test#17504shilomagen wants to merge 4 commits intonodejs:masterfrom
shilomagen wants to merge 4 commits intonodejs:masterfrom
Conversation
apapirovski
reviewed
Dec 6, 2017
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
LGTM but some small changes required
Contributor
There was a problem hiding this comment.
Could you undo this change? It should stay lined up.
Contributor
There was a problem hiding this comment.
Same for these two lines. They should be lined up as before.
Contributor
There was a problem hiding this comment.
Please keep the space to the left and right within the braces.
Contributor
There was a problem hiding this comment.
The process.on('exit') can be removed as server.close() needs to run before the process will exit.
Contributor
There was a problem hiding this comment.
Same as above, please add the spaces back in.
apapirovski
approved these changes
Dec 6, 2017
Contributor
There was a problem hiding this comment.
This doesn't strictly need the common.mustCall but it's not a deal breaker. (If you do remove it, you'll need to also remove the const common = part above (but keep the actual require).
Contributor
Author
|
@apapirovski all of your comments were fixed, thanks! |
shilomagen
changed the title
shilomagen
changed the title
lpinca
approved these changes
Dec 7, 2017
maclover7
approved these changes
Dec 7, 2017
Contributor
Bamieh
approved these changes
Dec 8, 2017
maclover7
added
the
author ready
Contributor
3 tasks
Contributor
|
Landed in 6a089f9 |
apapirovski
pushed a commit
that referenced
this pull request
Dec 8, 2017
PR-URL: #17504 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17504 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17504 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Merged
addaleax
removed
the
author ready
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17504 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17504 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17504 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Hi, first PR to NodeJS.
Worked on improving test by using Countdown:
#17169
Worked on file test-http-set-cookies.js
#goodnesssquad