Skip to content

test: Update test-http-client-agent to use countdown timer #17325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daxlab wants to merge 1 commit into from
Closed

test: Update test-http-client-agent to use countdown timer #17325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: Update test-http-client-agent to use countdown timer 
Fixes: #17169
  • Loading branch information
@daxlab
daxlab committed Nov 26, 2017
commit a01d39cb5ce35c0154bf30d7326461ae03ba75d2
16 changes: 9 additions & 7 deletions test/parallel/test-http-client-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
const common = require('../common');
const assert = require('assert');
const http = require('http');
const Countdown = require('../common/countdown');

let name;
const max = 3;
let count = 0;

const server = http.Server(common.mustCall((req, res) => {
if (req.url === '/0') {
Expand All @@ -45,21 +45,23 @@ server.listen(0, common.mustCall(() => {
request(i);
}));

const countdown = new Countdown(max, () => {
assert(!http.globalAgent.sockets.hasOwnProperty(name));
assert(!http.globalAgent.requests.hasOwnProperty(name));
server.close();
});

function request(i) {
const req = http.get({
port: server.address().port,
path: `/${i}`
}, function(res) {
const socket = req.socket;
socket.on('close', common.mustCall(() => {
++count;
if (count < max) {
countdown.dec();
if (countdown.remaining > 0) {
assert.strictEqual(http.globalAgent.sockets[name].includes(socket),
false);
} else {
assert(!http.globalAgent.sockets.hasOwnProperty(name));
assert(!http.globalAgent.requests.hasOwnProperty(name));
server.close();
}
}));
res.resume();
Expand Down