Skip to content

Fix two compiler warnings #16726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnoordhuis merged 2 commits into from
Nov 7, 2017
Merged

Fix two compiler warnings #16726

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9087a1d
src: fix -Winconsistent-missing-override warning
bnoordhuis Nov 3, 2017
02bad59
src: fix -Wunused-result warning
bnoordhuis Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: fix -Wunused-result warning 
Fix a compiler warning that was introduced in commit c3dc0e0
("src: add CollectExceptionInfo & errors.SystemError") by adding
a `.FromJust()` call.

PR-URL: #16726
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
  • Loading branch information
@bnoordhuis
bnoordhuis committed Nov 7, 2017
commit 02bad59f003d03bf64c59874cd31bd29202a194a
2 changes: 1 addition & 1 deletion src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ void CollectExceptionInfo(Environment* env,

if (syscall != nullptr) {
obj->Set(env->context(), env->syscall_string(),
OneByteString(env->isolate(), syscall));
OneByteString(env->isolate(), syscall)).FromJust();
}
}

Expand Down