Skip to content

crypto, errors: Add CryptoError to internal/errors, update crypto.setEngine #16529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 5 commits into from
Closed

crypto, errors: Add CryptoError to internal/errors, update crypto.setEngine #16529

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
181aef3
test: add `additional` option to expectsError
jasnell Oct 26, 2017
6ed4fb8
errors: add CryptoError
jasnell Oct 26, 2017
f36bd9d
crypto: use internal/errors CryptoError for setEngine
jasnell Oct 26, 2017
3762d2a
[Squash] fix test failure on windows
jasnell Oct 27, 2017
5fce91e
[Squash] nits
jasnell Oct 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
errors: add CryptoError 
A new internal/errors type that provides access to the
`opensslErrorStack`, code, and message.
  • Loading branch information
@jasnell
jasnell committed Oct 30, 2017
commit 6ed4fb8a856c494d513e4f04d483c3f470d0a9ba
21 changes: 21 additions & 0 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
// message may change, the code should not.

const kCode = Symbol('code');
const kInfo = Symbol('info');
const messages = new Map();

const { kMaxLength } = process.binding('buffer');
Expand Down Expand Up @@ -58,6 +59,25 @@ function makeNodeError(Base) {
};
}

class CryptoError extends makeNodeError(Error) {
constructor(key, context, ...args) {
super(key, args);
Object.defineProperty(this, kInfo, {
value: context || {},
enumerable: false,
configurable: false
});
}

get info() {
return this[kInfo];
}

get opensslErrorStack() {
return this[kInfo].opensslErrorStack;
}
}

class AssertionError extends Error {
constructor(options) {
if (typeof options !== 'object' || options === null) {
Expand Down Expand Up @@ -128,6 +148,7 @@ module.exports = exports = {
RangeError: makeNodeError(RangeError),
URIError: makeNodeError(URIError),
AssertionError,
CryptoError,
E // This is exported only to facilitate testing.
};

Expand Down