Skip to content

test: increase coverage for ModuleMap #16045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robtpaton wants to merge 8 commits into from
Closed

test: increase coverage for ModuleMap #16045

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
82e91df
test: increase coverage for ModuleMap
robtpaton Oct 6, 2017
f121d97
Started adding tests
robtpaton Oct 6, 2017
8ec3e59
add test for ModuleMap set with ModuleJob but bad url
Mousius Oct 6, 2017
3f3608f
Finished tests
robtpaton Oct 6, 2017
f5cd4c5
Fix typo
robtpaton Oct 6, 2017
5ead8e0
Use common for asserting errors are thrown
robtpaton Oct 13, 2017
0f9db3e
[Squash] Address nits
jasnell Oct 15, 2017
9888535
squash; add third argument
Trott Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Finished tests
  • Loading branch information
@robtpaton @Trott
robtpaton authored and Trott committed Nov 1, 2017
commit 3f3608f927165c491b92a2f34751ffcfef92428c
23 changes: 17 additions & 6 deletions test/es-module/test-esm-loader-modulemap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,32 @@ const moduleJob = new ModuleJob(loader, stubModule.module);

assert.throws(() => {
moduleMap.get(1);
}, 'TypeError [ERR_INVALID_ARG_TYPE]: The "url" argument must be of type string');
}, /TypeError \[ERR_INVALID_ARG_TYPE\]: The "url" argument must be of type string/);

assert.doesNotThrow(() => {
moduleMap.get('somestring');
});

assert.throws(() => {
moduleMap.has(1);
}, 'TypeError [ERR_INVALID_ARG_TYPE]: The "url" argument must be of type string');
moduleMap.set(1, moduleJob);
}, /TypeError \[ERR_INVALID_ARG_TYPE\]: The "url" argument must be of type string/);

assert.doesNotThrow(() => {
moduleMap.has('somestring');
moduleMap.set('somestring', moduleJob);
});

assert.throws(() => {
moduleMap.set(1, moduleJob);
}, 'TypeError [ERR_INVALID_ARG_TYPE]: The "url" argument must be of type string');
moduleMap.set('somestring', 'notamodulejob');
}, /TypeError \[ERR_INVALID_ARG_TYPE\]: The "job" argument must be of type ModuleJob/);

assert.doesNotThrow(() => {
moduleMap.set('somestring', moduleJob);
});

assert.throws(() => {
moduleMap.has(1);
}, /TypeError \[ERR_INVALID_ARG_TYPE\]: The "url" argument must be of type string/);

assert.doesNotThrow(() => {
moduleMap.has('somestring');
});