Skip to content

[v6.x backport] tools: apply stricter indentation rules to tools #14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

[v6.x backport] tools: apply stricter indentation rules to tools #14360

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13308b2
tools: remove no-useless-regex-char-class-escape
Trott Jan 1, 2017
8ab455e
tools: fix indentation in required-modules.js
Trott Jun 18, 2017
1ebad50
tools: apply stricter indentation rules to tools
Trott Jun 18, 2017
1088e81
tools: fix error in custom ESLint rule
Trott Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: remove no-useless-regex-char-class-escape 
The `no-useless-regex-char-class-escape` custom lint rule was introduced
as a less aggressive alternative to some enhancements that were
introduced into ESLint. Those enhancements were blocking us from
updating ESLint. However, they have since been relaxed and the custom
rule is no longer needed. Remove it.

PR-URL: #10561
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
  • Loading branch information
@Trott
Trott committed Jul 19, 2017
commit 13308b2bee96cd78c1b02c529bca114f790ae55f
1 change: 0 additions & 1 deletion .eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ rules:
# Custom rules in tools/eslint-rules
align-multiline-assignment: 2
assert-throws-arguments: [2, { requireTwo: true }]
no-useless-regex-char-class-escape: [2, { override: ['[', ']'] }]

# Global scoped method and vars
globals:
Expand Down
190 changes: 0 additions & 190 deletions tools/eslint-rules/no-useless-regex-char-class-escape.js
View file
Open in desktop

This file was deleted.