Skip to content

test,fs: delay unlink in test-regress-GH-4027.js #14010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaimecbernardo wants to merge 2 commits into from
Closed

test,fs: delay unlink in test-regress-GH-4027.js #14010

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0dfdd2
test,fs: delay unlink in test-regress-GH-4027.js
jaimecbernardo Jun 30, 2017
0de3034
fixup: use common.platformTimeout
jaimecbernardo Jul 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test,fs: delay unlink in test-regress-GH-4027.js 
The sequential/test-regress-GH-4027 test is flaky with an increased
system load, failing when the watched file is unlinked before the
first state of the watched file is retrieved.

After increasing the delay before unlinking and calling setTimeout
after watchFile, the flakiness stopped reproducing.

Fixes: #13800
  • Loading branch information
@jaimecbernardo
jaimecbernardo committed Jun 30, 2017
commit e0dfdd23c714390fb35577feeb4d903df01b479f
3 changes: 2 additions & 1 deletion test/sequential/test-regress-GH-4027.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ common.refreshTmpDir();

const filename = path.join(common.tmpDir, 'watched');
fs.writeFileSync(filename, 'quis custodiet ipsos custodes');
setTimeout(fs.unlinkSync, 100, filename);

fs.watchFile(filename, { interval: 50 }, common.mustCall(function(curr, prev) {
assert.strictEqual(prev.nlink, 1);
assert.strictEqual(curr.nlink, 0);
fs.unwatchFile(filename);
}));

setTimeout(fs.unlinkSync, 300, filename);
Copy link
Member

@jasnell jasnell Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common.platformTimeout?