test: remove needless RegExp capturing

Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward.
nodejs · vsemozhetbyt · Jun 18, 2017 · Jun 18, 2017 · Jun 18, 2017 · Jun 18, 2017
commit aa006ffb524d77ee3c51753cfd2a0efa78f72e57
diff --git a/test/common/index.js b/test/common/index.js
@@ -433,7 +433,7 @@ function leakedGlobals() {
       leaked.push(val);
 
   if (global.__coverage__) {
-    return leaked.filter((varname) => !/^(cov_|__cov)/.test(varname));
+    return leaked.filter((varname) => !/^(?:cov_|__cov)/.test(varname));
   } else {
     return leaked;
   }

diff --git a/test/debugger/helper-debugger-repl.js b/test/debugger/helper-debugger-repl.js
@@ -51,7 +51,7 @@ function startDebugger(scriptToDebug) {
   child.stderr.pipe(process.stderr);
 
   child.on('line', function(line) {
-    line = line.replace(/^(debug> *)+/, '');
+    line = line.replace(/^(?:debug> *)+/, '');
     console.log(line);
     assert.ok(expected.length > 0, `Got unexpected line: ${line}`);
 

diff --git a/test/inspector/inspector-helper.js b/test/inspector/inspector-helper.js
@@ -521,11 +521,11 @@ exports.startNodeForInspectorTest = function(callback,
     clearTimeout(timeoutId);
     console.log('[err]', text);
     if (found) return;
-    const match = text.match(/Debugger listening on ws:\/\/(.+):(\d+)\/(.+)/);
+    const match = text.match(/Debugger listening on ws:\/\/.+:(\d+)\/.+/);
     found = true;
     child.stderr.removeListener('data', dataCallback);
     assert.ok(match, text);
-    callback(new Harness(match[2], child));
+    callback(new Harness(match[1], child));
   });
 
   child.stderr.on('data', dataCallback);

diff --git a/test/parallel/test-buffer-prototype-inspect.js b/test/parallel/test-buffer-prototype-inspect.js
@@ -19,5 +19,5 @@ const util = require('util');
 
 {
   const buf = Buffer.from('x'.repeat(51));
-  assert.ok(/^<Buffer (78 ){50}\.\.\. >$/.test(util.inspect(buf)));
+  assert.ok(/^<Buffer (?:78 ){50}\.\.\. >$/.test(util.inspect(buf)));
 }
diff --git a/test/parallel/test-net-connect-options-port.js b/test/parallel/test-net-connect-options-port.js
@@ -190,7 +190,7 @@ function canConnect(port) {
 
 function asyncFailToConnect(port) {
   const onError = () => common.mustCall(function(err) {
-    const regexp = /^Error: connect (E\w+)(.+)$/;
+    const regexp = /^Error: connect E\w+.+$/;
     assert(regexp.test(String(err)), String(err));
   });
 

diff --git a/test/parallel/test-process-emitwarning.js b/test/parallel/test-process-emitwarning.js
@@ -12,7 +12,7 @@ const testType = 'CustomWarning';
 
 process.on('warning', common.mustCall((warning) => {
   assert(warning);
-  assert(/^(Warning|CustomWarning)/.test(warning.name));
+  assert(/^(?:Warning|CustomWarning)/.test(warning.name));
   assert.strictEqual(warning.message, testMsg);
   if (warning.code) assert.strictEqual(warning.code, testCode);
   if (warning.detail) assert.strictEqual(warning.detail, testDetail);

diff --git a/test/parallel/test-process-setuid-setgid.js b/test/parallel/test-process-setuid-setgid.js
@@ -46,12 +46,12 @@ if (process.getuid() !== 0) {
 
   assert.throws(
     () => { process.setgid('nobody'); },
-    /^Error: (EPERM, .+|setgid group id does not exist)$/
+    /^Error: (?:EPERM, .+|setgid group id does not exist)$/
   );
 
   assert.throws(
     () => { process.setuid('nobody'); },
-    /^Error: (EPERM, .+|setuid user id does not exist)$/
+    /^Error: (?:EPERM, .+|setuid user id does not exist)$/
   );
   return;
 }

diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js
@@ -21,10 +21,10 @@ const actual_keys = Object.keys(process.versions).sort();
 
 assert.deepStrictEqual(actual_keys, expected_keys);
 
-assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.ares));
-assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.http_parser));
-assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.node));
-assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.uv));
-assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.zlib));
-assert(/^\d+\.\d+\.\d+(\.\d+)?( \(candidate\))?$/.test(process.versions.v8));
+assert(/^\d+\.\d+\.\d+(?:-.*)?$/.test(process.versions.ares));
+assert(/^\d+\.\d+\.\d+(?:-.*)?$/.test(process.versions.http_parser));
+assert(/^\d+\.\d+\.\d+(?:-.*)?$/.test(process.versions.node));
+assert(/^\d+\.\d+\.\d+(?:-.*)?$/.test(process.versions.uv));
+assert(/^\d+\.\d+\.\d+(?:-.*)?$/.test(process.versions.zlib));
+assert(/^\d+\.\d+\.\d+(?:\.\d+)?(?: \(candidate\))?$/.test(process.versions.v8));
 assert(/^\d+$/.test(process.versions.modules));
diff --git a/test/parallel/test-socket-address.js b/test/parallel/test-socket-address.js
@@ -12,6 +12,6 @@ server.listen(0, common.mustCall(function() {
     return -1;
   };
   assert.throws(() => this.address(),
-                /^Error: address ([\w|\s-\d])+$/);
+                /^Error: address [\w|\s-\d]+$/);
   server.close();
 }));
diff --git a/test/parallel/test-url-parse-invalid-input.js b/test/parallel/test-url-parse-invalid-input.js
@@ -17,7 +17,7 @@ const url = require('url');
   Symbol('foo')
 ].forEach((val) => {
   assert.throws(() => { url.parse(val); },
-                /^TypeError: Parameter "url" must be a string, not (undefined|boolean|number|object|function|symbol)$/);
+                /^TypeError: Parameter "url" must be a string, not (?:undefined|boolean|number|object|function|symbol)$/);
 });
 
 assert.throws(() => { url.parse('http://%E0%A4%A@fail'); },