Skip to content

module: restore and warn on require('.') usage with NODE_PATH #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind wants to merge 6 commits into from
Closed

module: restore and warn on require('.') usage with NODE_PATH #1363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
685d6e5
module: search NODE_PATH in require('.')
silverwind Apr 7, 2015
712e75c
Better module dir detection, add warning
silverwind Apr 7, 2015
9a2e885
Warn once through util.deprecate, refactor
silverwind Apr 11, 2015
affc1f5
Move dot tests to own file
silverwind Apr 16, 2015
5e84210
Fix test and nits
silverwind Apr 16, 2015
7a73480
Fix deprecation message
silverwind Apr 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move dot tests to own file
  • Loading branch information
@silverwind
silverwind committed Apr 16, 2015
commit affc1f5e9d978c862e99537c41d48668a28dabb2
15 changes: 15 additions & 0 deletions test/parallel/test-require-dot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
var common = require('../common');
var assert = require('assert');

var a = require(common.fixturesDir + '/module-require/relative/dot.js');
var b = require(common.fixturesDir + '/module-require/relative/dot-slash.js');

assert.equal(a.value, 42);
assert.equal(a, b, 'require(".") should resolve like require("./")');

process.env.NODE_PATH = common.fixturesDir + '/module-require/relative';
module._initPaths();

var c = require('.');

assert.equal(c, 42, 'require(".") should honor NODE_PATH');
8 changes: 1 addition & 7 deletions test/parallel/test-require-extensions-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
var common = require('../common');
var assert = require('assert');

require(common.fixturesDir + '/require-bin/bin/req.js');

var a = require(common.fixturesDir + '/module-require/relative/dot.js');
var b = require(common.fixturesDir + '/module-require/relative/dot-slash.js');

assert.equal(a.value, 42);
assert.equal(a, b, 'require(".") should resolve like require("./")');
require(common.fixturesDir + '/require-bin/bin/req.js');