Skip to content

Revert "module: allow require('.')" #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjihrig wants to merge 1 commit into from
Closed

Revert "module: allow require('.')" #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "module: allow require('.')" 
This reverts commit 6fc5e95.
  • Loading branch information
@cjihrig
cjihrig committed Apr 7, 2015
commit 99194118dcb3f63bab3bb6f927e18dd0cbb64fff
2 changes: 1 addition & 1 deletion lib/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ Module._resolveLookupPaths = function(request, parent) {
}

var start = request.substring(0, 2);
if (start !== '.' && start !== './' && start !== '..') {
if (start !== './' && start !== '..') {
var paths = modulePaths;
if (parent) {
if (!parent.paths) parent.paths = [];
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/module-require/relative/dot-slash.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/module-require/relative/dot.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/module-require/relative/index.js
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions test/parallel/test-require-extensions-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,3 @@ var common = require('../common');
var assert = require('assert');

require(common.fixturesDir + '/require-bin/bin/req.js');

var a = require(common.fixturesDir + '/module-require/relative/dot.js');
var b = require(common.fixturesDir + '/module-require/relative/dot-slash.js');

assert.equal(a.value, 42);
assert.equal(a, b, 'require(".") should resolve like require("./")');