Skip to content

lib: remove _debugger.js #12495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 2 commits into from
Closed

lib: remove _debugger.js #12495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f991f75
lib,src,test: update --debug/debug-brk comments
bnoordhuis Apr 18, 2017
857dd1a
lib: remove _debugger.js
bnoordhuis Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib,src,test: update --debug/debug-brk comments 
Overlooked in commit 47f8f74 ("src: remove support for --debug") from
earlier this month.
  • Loading branch information
@bnoordhuis
bnoordhuis committed Apr 18, 2017
commit f991f75e78cfaef4faa7d910c8de98565542ed20
2 changes: 1 addition & 1 deletion lib/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ Module.prototype.require = function(path) {


// Resolved path to process.argv[1] will be lazily placed here
// (needed for setting breakpoint when called with --debug-brk)
// (needed for setting breakpoint when called with --inspect-brk)
var resolvedArgv;


Expand Down
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3337,7 +3337,7 @@ void SetupProcessObject(Environment* env,
READONLY_PROPERTY(process, "traceDeprecation", True(env->isolate()));
}

// --debug-brk
// --inspect-brk
if (debug_options.wait_for_connect()) {
READONLY_PROPERTY(process, "_debugWaitConnect", True(env->isolate()));
}
Expand Down
2 changes: 1 addition & 1 deletion test/inspector/test-inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function setupExpectValue(value) {

function testBreakpointOnStart(session) {
console.log('[test]',
'Verifying debugger stops on start (--debug-brk option)');
'Verifying debugger stops on start (--inspect-brk option)');
const commands = [
{ 'method': 'Runtime.enable' },
{ 'method': 'Debugger.enable' },
Expand Down