doc: adds options for cpp linting to help section of Windows build script#11992
Closed
brennemo wants to merge 1 commit intonodejs:masterfrom
Closed
doc: adds options for cpp linting to help section of Windows build script#11992brennemo wants to merge 1 commit intonodejs:masterfrom
brennemo wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
gibfahn
approved these changes
Mar 22, 2017
Member
|
cc/ @refack |
Contributor
|
@brennemo Thank you for the contribution. A nit: it seems the commit title exceed required 50 characters and lacks subsystem prefix (@gibfahn, should it be |
Contributor
|
LGTM pending @vsemozhetbyt's comment |
Member
|
Good point @vsemozhetbyt , @brennemo maybe something like this for the commit message: Also your name in git is currently: People usually choose to use their full names for commits. To set your name globally you can do: git config --global user.name "Morgan Brenner"To change the author and commit message you can do: git commit --amend --author="Morgan Brenner <[email protected]>"
# Edit commit message when it pops up
git push --force-with-lease |
brennemo
force-pushed
the
help-lint-option
branch
from
ab470d6 to
e52cb17
Compare
Contributor
Author
|
Sure, I amended the author to add my last name and updated the commit message. |
vsemozhetbyt
approved these changes
Mar 23, 2017
Contributor
jasnell
approved these changes
Mar 23, 2017
richardlau
approved these changes
Mar 24, 2017
cjihrig
approved these changes
Mar 24, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 24, 2017
PR-URL: #11992 Fixes: #11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
|
Landed in a8a042a |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
PR-URL: #11992 Fixes: #11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
4 tasks
Contributor
|
should this be backported? |
Contributor
|
I'm +0.1 (it's a tiny documentation change, so little gain little risk) |
3 tasks
Member
Contributor
refack
pushed a commit
to refack/node
that referenced
this pull request
Aug 22, 2017
PR-URL: nodejs#11992 Fixes: nodejs#11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
180bec1 PR-URL: #11992 Fixes: #11971 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds options for cpp linting to help section of Windows build script
Fixes: #11971
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)