v4.x backport: http: make request.abort() destroy the socket#11765
Closed
lpinca wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
v4.x backport: http: make request.abort() destroy the socket#11765lpinca wants to merge 1 commit intonodejs:v4.x-stagingfrom
lpinca wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
`request.abort()` did not destroy the socket if it was called before a socket was assigned to the request and the request did not use an `Agent` or a Unix Domain Socket was used. Fixes: nodejs#10812 PR-URL: nodejs#10818 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Member
Author
|
cc: @MylesBorins It would be nice to have this in v4.8.1 |
Contributor
|
looks like this is still having failures. It is possible that the next v4.x release will be the last Active LTS release of v4 and an RC has already gone out. You will need to get the tests passing ASAP if we are going to try and roll it into v4.8.1 |
Member
Author
|
@MylesBorins the only failures I can see are on osx and on ppcle-ubuntu1404. |
Member
Author
Member
Author
|
CI is 100% green. |
Contributor
|
landed in 0fe9ac3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4.x backport of #10818.
Commit landed cleanly and tests pass on my machine (macOS 10.11.6).
I'm opening this PR as per this comment.
CI: https://ci.nodejs.org/job/node-test-pull-request/6758/