Skip to content

deps: update V8 to 5.7 #11752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 10 commits into from
Mar 25, 2017
Merged

deps: update V8 to 5.7 #11752

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c459d8e
deps: update V8 to 5.7.492.69
targos Mar 21, 2017
89d8dc9
src: update NODE_MODULE_VERSION to 54
targos Mar 21, 2017
3f9c8fb
deps: limit regress/regress-crbug-514081 v8 test
mhdawson May 9, 2016
83bf297
deps: cherry-pick V8 ValueSerializer changes
addaleax Mar 8, 2017
fcc58bf
deps: cherry-pick a927f81c7 from V8 upstream
addaleax Mar 8, 2017
3471d63
deps: cherry-pick 0ba513f05 from V8 upstream
fhinkel Mar 6, 2017
8394b05
deps: cherry-pick c5c570f from upstream V8
targos Mar 17, 2017
07088e6
deps: backport 39642fa from upstream V8
targos Mar 21, 2017
9c9e2d7
deps: backport 3297130 from upstream V8
targos Mar 23, 2017
ed12ea3
src: update inspector code to match upstream API
targos Feb 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: update inspector code to match upstream API 
PR-URL: #11752
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
  • Loading branch information
@targos
targos committed Mar 25, 2017
commit ed12ea371c5352b4b13f9f1c4e0f577fbd30bb2a
11 changes: 7 additions & 4 deletions src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,15 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel {
explicit ChannelImpl(AgentImpl* agent): agent_(agent) {}
virtual ~ChannelImpl() {}
private:
void sendProtocolResponse(int callId, const StringView& message) override {
sendMessageToFrontend(message);
void sendResponse(
int callId,
std::unique_ptr<v8_inspector::StringBuffer> message) override {
sendMessageToFrontend(message->string());
}

void sendProtocolNotification(const StringView& message) override {
sendMessageToFrontend(message);
void sendNotification(
std::unique_ptr<v8_inspector::StringBuffer> message) override {
sendMessageToFrontend(message->string());
}

void flushProtocolNotifications() override { }
Expand Down