Conversation
|
@zkat 😭 Looks like |
Fishrock123
left a comment
There was a problem hiding this comment.
make test-npm passes, things seem fine. LGTM
|
I literally looked for a weirdly cased readme this time. |
|
|
|
@targos can you share more details? |
|
@zkat sure. here is the full output: http://pastebin.com/AP9e1eyc |
|
I re-ran the tests with current master and get exactly the same failures so they are likely unrelated to this update. |
|
@targos last I checked, |
|
Landed in e1834ff, so sorry I forgot! 😰 |
PR-URL: #11389 Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #11389 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Notable changes:
* buffer:
- do not segfault on out-of-range index (Timothy Gu)
#11927
* crypto:
- Fix memory leak if certificate is revoked (Tom Atkinson)
#12089
* deps:
* upgrade npm to 4.2.0 (Kat Marchán)
#11389
* fix async await desugaring in V8 (Michaël Zasso)
#12004
* readline:
- add option to stop duplicates in history (Danny Nemer)
#2982
* src:
- add native URL class (James M Snell)
#11801
PR-URL: #12104
Notable changes:
* buffer:
- do not segfault on out-of-range index (Timothy Gu)
#11927
* crypto:
- Fix memory leak if certificate is revoked (Tom Atkinson)
#12089
* deps:
* upgrade npm to 4.2.0 (Kat Marchán)
#11389
* fix async await desugaring in V8 (Michaël Zasso)
#12004
* readline:
- add option to stop duplicates in history (Danny Nemer)
#2982
* src:
- add native URL class (James M Snell)
#11801
PR-URL: #12104
|
@zkat @iarna when will he get |
Notable changes:
* buffer:
- do not segfault on out-of-range index (Timothy Gu)
nodejs/node#11927
* crypto:
- Fix memory leak if certificate is revoked (Tom Atkinson)
nodejs/node#12089
* deps:
* upgrade npm to 4.2.0 (Kat Marchán)
nodejs/node#11389
* fix async await desugaring in V8 (Michaël Zasso)
nodejs/node#12004
* readline:
- add option to stop duplicates in history (Danny Nemer)
nodejs/node#2982
* src:
- add native URL class (James M Snell)
nodejs/node#11801
PR-URL: nodejs/node#12104
Signed-off-by: Ilkka Myller <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
depsDescription of Change
$(npm get cache)/_logsand store multiple log files. (@KenanY) (@othiym23) (@isaacs) (@iarna)npm run-scriptnow exits with the child process' exit code on exit. (@kapals)Changelogs
v4.2.0r: @Fishrock123
r: @addaleax
r: @jasnell