Skip to content

tls: do not crash on STARTTLS when OCSP requested #10706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 7 commits into from
Closed

tls: do not crash on STARTTLS when OCSP requested #10706

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1b114e
tls: do not crash on STARTTLS when OCSP requested
indutny Jan 9, 2017
caa7ba1
fix
indutny Jan 9, 2017
3ef170f
fix
indutny Jan 10, 2017
7473f55
fix
indutny Jan 10, 2017
584b455
fix
indutny Jan 10, 2017
20b187b
fix
indutny Feb 3, 2017
36fd2ce
fix
indutny Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@indutny
indutny committed Jan 9, 2017
commit caa7ba1e5d73f92126e8e064af34692fb9eb0478
3 changes: 1 addition & 2 deletions test/parallel/test-tls-starttls-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,13 @@ const server = net.createServer(common.mustCall((s) => {
}),

SNICallback: common.mustCall((hostname, callback) => {
assert.equal(hostname, 'test.test');
assert.deepEqual(hostname, 'test.test');

callback(null, null);
Copy link
Contributor

@sam-github sam-github Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://github.com/nodejs/node/blob/master/doc/api/tls.md#tlscreateserveroptions-secureconnectionlistener

SNICallback should invoke cb(null, ctx), where ctx is a SecureContext instance.

Is (null, null) valid? Should it be valid?

Copy link
Member Author

@indutny indutny Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is valid and it should be valid.

})
});

tlsSocket.on('secure', common.mustCall(() => {
console.log('hello');
tlsSocket.end();
server.close();
}));
Expand Down