-
-
Notifications
You must be signed in to change notification settings - Fork 35k
doc: some fixes in repl.md #10160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
doc: some fixes in repl.md #10160
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
9615910
doc: var => let / const in repl.md
vsemozhetbyt 3e18789
doc: white space unification in repl.md
vsemozhetbyt 743f84d
doc: fix an output example in repl.md
vsemozhetbyt a7501f2
doc: fix a function name in repl.md
vsemozhetbyt 402c625
doc: name anonymous functions in repl.md
vsemozhetbyt e20c785
doc: document argument variant in repl.md
vsemozhetbyt 4357059
doc: add the valid link for curl(1) in repl.md
vsemozhetbyt 9c7054b
doc: replace anonymous functions in repl.md
vsemozhetbyt cdeb85e
test: move long-running test to sequential
Trott da077ee
test: refactor test-dgram-bind-default-address
mbchoa 22e2c47
build: fix node_g target
danbev a244147
test: check result of uv_loop_init and uv_write
bnoordhuis 1b25214
test: use const and strictEqual in test-os-homedir-no-envvar
codeVana 61d6293
url: improve URLSearchParams spec compliance
TimothyGu ac78812
test: refactor test-domain-exit-dispose-again
Ethan-Arrowood b0c10a2
test: refactor test-domain-from-timer
586b787
doc: removing extra space in README
df4018e
doc: reword variable declaration note in repl.md
vsemozhetbyt 29b2e88
test: improve test-fs-read-stream.js
jennabelle c6eae5a
doc: adding missing - in README
8960383
test: refactor test-beforeexit-event
radelmann 83d9cd8
test: refactor test-https-agent-session-reuse
dpaez fd6999e
test: improves test-tls-client-verify
57f993d
test: renamed assert.Equal to assert.strictEqual
triscuitoraus e6a0c39
test: changed assert.equal to assert.strictEqual
zina-olson 558fa1c
test: change assert.equal to assert.strictEqual
deb9cc0
test: use `assert.strictEqual`
anoff 68488e9
test: fix error in test-cluster-worker-death.js
1e4b9a1
test: refactor test-crypto-hmac
eudaimos 2d0ce51
doc: update `path.format` description and examples
anoff 6967ed4
test: refactor test-net-keepalive.js
kmccmk9 df39784
http: verify client method is a string
lucamaraschi a0a6ff2
doc: add some info on `tty#setRawMode()`
Fishrock123 6dd0754
test: fix flaky test-net-socket-timeout
Trott 9a5d475
http: remove stale timeout listeners
f0da38a
test: increase test coverage of BufferList
joyeecheung 444b907
test: refactor test-http-unix-socket
6aacef7
test: check for error on invalid signal
mattcphillips a8137dd
tools: add macosx-firwall script to avoid popups
danbev def6dfb
test: set stdin too for pseudo-tty tests
addaleax b8fc9a3
test: add stdin-setrawmode.out file
bc335c0
doc: buffer allocation throws for negative size
joyeecheung f9aadfb
inspector: move options parsing
d8c7534
inspector: stop relying on magic strings
3d24856
doc: revert documenting argument form in repl.md
vsemozhetbyt cffbb32
doc: add note to parallelize make
0cd1f54
doc: standardizing on make -j4
4d11c2c
lib,test: use consistent operator linebreak style
targos 7c2dbd1
tools: enforce consistent operator linebreak style
targos aa77b76
lib,src: support values > 4GB in heap statistics
bnoordhuis 8dbf1af
test: stream readableListening internal state
8621ccc
test: stream readableState readingMore state
chmln f5c2c8c
test: improving crypto fips
9f58e02
test: improve buffer transcode
a84017a
url, test: including base argument in originFor
joyeecheung 5607228
test: use ES6 in test-debugger-client.js
edsadr 14b0b44
doc: fix typo in code example of 'path' module
pallxk 10929f6
test: fail for missing output files
addaleax f418a22
doc: modernize child_process example code
vsemozhetbyt 9ee915b
buffer: handle UCS2 `.fill()` properly on BE
addaleax d4f00fe
buffer: fix single-character string filling
addaleax c3839f7
tls: fix/annotate connect arg comments
sam-github d4050b3
tls: document and test option-less createServer
sam-github 475b8db
test: tls key/cert ordering not necessary
sam-github a28e949
tls: do not refer to secureOptions as flags
sam-github caa7fa9
doc: rework tls for accuracy and clarity
sam-github db50307
test: var to const in tls-no-cert-required
sam-github fa4f158
test: replace var with const in test-require-dot
amarzavery a8e8708
test: add ES6 and strictEqual to test-fs-truncate
edsadr 499fc7a
test: refactor test-handle-wrap-close-abort
Trott 50cb3a3
doc: document argument variant in the repl.md
vsemozhetbyt 7346e55
test: refactor http pipelined socket test
Trott 10891a1
test: refactor assert.equal, update syntax to ES6
8bad37a
test: refactor test-https-truncate
Trott 5f18b40
doc: var => let / const in repl.md
vsemozhetbyt bed9aae
doc: white space unification in repl.md
vsemozhetbyt 9bef034
doc: fix an output example in repl.md
vsemozhetbyt 67c2a7d
doc: fix a function name in repl.md
vsemozhetbyt d665e39
doc: name anonymous functions in repl.md
vsemozhetbyt 5f31da7
doc: document argument variant in repl.md
vsemozhetbyt d5861ad
doc: add the valid link for curl(1) in repl.md
vsemozhetbyt 0c32eb5
doc: replace anonymous functions in repl.md
vsemozhetbyt 936263e
doc: reword variable declaration note in repl.md
vsemozhetbyt 588a5d5
doc: revert documenting argument form in repl.md
vsemozhetbyt 10c0137
doc: resolved merge conflict
vsemozhetbyt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: reword variable declaration note in repl.md
- Loading branch information
commit df4018e4c5beec58d08a19f3f63a5e75f93f2711
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a cumbersome distinction between
constandvar, and `let. Couldn't it just be something like this?Especially since the phrase is immediately preceded by "Unless otherwise scoped within blocks or functions".
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lance But it is exactly this remark — "Unless otherwise scoped within blocks or functions" — that prevents placing
const,var, andletin the same list:varis not block scoped. Maybe you or somebody else could propose the whole clear concise sentence there? I am not a native speaker, so I am a bit clumsy there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
constandletdeclarations are block scoped, and thevardeclaration is function scoped. I think this sentence covers both. I'm not sure if I have a wording that is clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Done.