fixup

ronag · ronag · commit c48885aa10e5 · 2020-03-15T13:39:35.000+01:00
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -665,9 +665,12 @@ function clearIncoming(req) {
   if (parser && parser.incoming === req) {
     if (req.readableEnded) {
       parser.incoming = null;
+      req.emit('close');
     } else {
       req.on('end', clearIncoming);
     }
+  } else {
+    req.emit('close');
   }
 }
 
@@ -678,7 +681,6 @@ function resOnFinish(req, res, socket, state, server) {
   assert(state.incoming.length === 0 || state.incoming[0] === req);
 
   state.incoming.shift();
-  clearIncoming(req);
 
   // If the user never called req.read(), and didn't pipe() or
   // .resume() or .on('data'), then we call req._dump() so that the
@@ -687,9 +689,7 @@ function resOnFinish(req, res, socket, state, server) {
     req._dump();
 
   res.detachSocket(socket);
-  // TODO(ronag): streamify IncomingMessage.destroy()
-  req._readableState.destroyed = true;
-  req.emit('close');
+  clearIncoming(req);
   process.nextTick(emitCloseNT, res);
 
   if (res._last) {
diff --git a/test/parallel/test-http-no-read-no-dump.js b/test/parallel/test-http-no-read-no-dump.js
@@ -1,6 +1,7 @@
 'use strict';
 const common = require('../common');
 const http = require('http');
+const assert = require('assert');
 
 let onPause = null;
 
@@ -11,6 +12,14 @@ const server = http.createServer((req, res) => {
   res.writeHead(200);
   res.flushHeaders();
 
+  let closed = false;
+  req.on('close', common.mustCall(() => {
+    closed = true;
+  }));
+  req.on('end', common.mustCall(() => {
+    assert.strictEqual(closed, false);
+  }));
+
   req.connection.on('pause', () => {
     res.end();
     onPause();
