worker: do not look up context twice in PostMessage

addaleax · addaleax · commit 4f1268284b92 · 2021-05-23T16:20:41.000+02:00
Refs: #38780 (comment)
diff --git a/src/node_messaging.cc b/src/node_messaging.cc
@@ -840,11 +840,11 @@ BaseObjectPtr<BaseObject> MessagePortData::Deserialize(
 }
 
 Maybe<bool> MessagePort::PostMessage(Environment* env,
+                                     Local<Context> context,
                                      Local<Value> message_v,
                                      const TransferList& transfer_v) {
   Isolate* isolate = env->isolate();
   Local<Object> obj = object(isolate);
-  Local<Context> context = obj->GetCreationContext().ToLocalChecked();
 
   std::shared_ptr<Message> msg = std::make_shared<Message>();
 
@@ -986,7 +986,7 @@ void MessagePort::PostMessage(const FunctionCallbackInfo<Value>& args) {
     return;
   }
 
-  Maybe<bool> res = port->PostMessage(env, args[0], transfer_list);
+  Maybe<bool> res = port->PostMessage(env, context, args[0], transfer_list);
   if (res.IsJust())
     args.GetReturnValue().Set(res.FromJust());
 }
diff --git a/src/node_messaging.h b/src/node_messaging.h
@@ -236,6 +236,7 @@ class MessagePort : public HandleWrap {
   // If this port is closed, or if there is no sibling, this message is
   // serialized with transfers, then silently discarded.
   v8::Maybe<bool> PostMessage(Environment* env,
+                              v8::Local<v8::Context> context,
                               v8::Local<v8::Value> message,
                               const TransferList& transfer);
 

Original file line number	Diff line number	Diff line change
`@@ -840,11 +840,11 @@ BaseObjectPtr<BaseObject> MessagePortData::Deserialize(`
`840`	`840`	`}`
`841`	`841`
`842`	`842`	`Maybe<bool> MessagePort::PostMessage(Environment* env,`
	`843`	`+ Local<Context> context,`
`843`	`844`	`Local<Value> message_v,`
`844`	`845`	`const TransferList& transfer_v) {`
`845`	`846`	`Isolate* isolate = env->isolate();`
`846`	`847`	`Local<Object> obj = object(isolate);`
`847`		`- Local<Context> context = obj->GetCreationContext().ToLocalChecked();`
`848`	`848`
`849`	`849`	`std::shared_ptr<Message> msg = std::make_shared<Message>();`
`850`	`850`
`@@ -986,7 +986,7 @@ void MessagePort::PostMessage(const FunctionCallbackInfo<Value>& args) {`
`986`	`986`	`return;`
`987`	`987`	`}`
`988`	`988`
`989`		`- Maybe<bool> res = port->PostMessage(env, args[0], transfer_list);`
	`989`	`+ Maybe<bool> res = port->PostMessage(env, context, args[0], transfer_list);`
`990`	`990`	`if (res.IsJust())`
`991`	`991`	`args.GetReturnValue().Set(res.FromJust());`
`992`	`992`	`}`