Skip to content

Improve the user-select CSS code usage#5565

Merged
knolleary merged 1 commit intonode-red:devfrom
bonanitech:user-select-css
Mar 13, 2026
Merged

Improve the user-select CSS code usage#5565
knolleary merged 1 commit intonode-red:devfrom
bonanitech:user-select-css

Conversation

@bonanitech
Copy link
Copy Markdown
Contributor

@bonanitech bonanitech commented Mar 13, 2026

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Improves usage of the user-select CSS property by using SCSS mixins whenever user-selection customization is required, ensuring consistent behavior across all browsers. Previously, that wouldn't work in some places with Safari, because it only supports the -webkit-user-select property that was missing in the code.

Additionally, it removes obsolete vendor-prefixed code related to that property.

EDIT: I forgot to add the links below.

https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/user-select

https://caniuse.com/mdn-css_properties_user-select

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit 2055d1d into node-red:dev Mar 13, 2026
5 checks passed
@bonanitech bonanitech deleted the user-select-css branch March 13, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants