Skip to content

Fix "connected to ..." log string in tcp in/out nodes using TLS#5484

Merged
knolleary merged 1 commit intonode-red:masterfrom
marcows:log-connected
Mar 24, 2026
Merged

Fix "connected to ..." log string in tcp in/out nodes using TLS#5484
knolleary merged 1 commit intonode-red:masterfrom
marcows:log-connected

Conversation

@marcows
Copy link
Copy Markdown
Contributor

@marcows marcows commented Feb 13, 2026

It was wrongly displayed as "status.connected"
instead of e.g. "connected to 127.0.0.1:6789"

Also remove the separator spaces from function invocation to be equal to the invocation in non-TLS mode in the else path below.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

It was wrongly displayed as "status.connected"
instead of e.g. "connected to 127.0.0.1:6789"

Also remove the separator spaces from function invocation to be equal to
the invocation in non-TLS mode in the else path below.
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 13, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: marcows / name: Markus Heidelberg (9b3e9ee)

@dceejay dceejay self-requested a review February 15, 2026 10:06
@dceejay
Copy link
Copy Markdown
Member

dceejay commented Feb 15, 2026

Yes - good catch - thanks

Copy link
Copy Markdown
Member

@dceejay dceejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@knolleary knolleary merged commit 9d46b29 into node-red:master Mar 24, 2026
5 checks passed
@marcows marcows deleted the log-connected branch March 24, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants