Doing topic checking also in publish requests#190
Open
jacoposartini wants to merge 5 commits intonjouanin:masterfrom
Open
Doing topic checking also in publish requests#190jacoposartini wants to merge 5 commits intonjouanin:masterfrom
jacoposartini wants to merge 5 commits intonjouanin:masterfrom
Conversation
Contributor
|
I find this update very useful! Thank you |
Contributor
|
I was really surprised when I tried it a while ago and realized that it didn't check on publish. I would definitely use this feature! However I think the plugin needs to be able to differentiate between publish and subscribe, to allow more advanced rules, for example if someone should be able to read from a topic but not publish to it. |
Contributor
|
I suggest you fork @jacoposartini repo, make the changes and start a new pull request |
Moustikitos
added a commit
to Moustikitos/hbmqtt
that referenced
this pull request
Jun 5, 2020
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on a Django project which consists of a platform for remote control of IoT devices.
To integrate MQTT with the database I wrote a plugin in order to limit the access of users only to the topics to which they are authorized.
When doing some tests I realized that the topic checking is only performed in the sub requests, while in the pub requests anyone can publish in the topics reserved for other users.
Looking at the code in broker.py I found that the method topic_filtering() is called only in the sub requests.
To solve this problem I added a method that calls the topic filtering in the pub requests that come from the users.