Skip to content

Allow cancelling the popovers by clicking away #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steurt wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Allow cancelling the popovers by clicking away #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
82e6366
Allow to cancel the popovers by clicking away
Jun 3, 2020
0819012
Allow to cancel the popovers by clicking away
Jun 3, 2020
ac53812
Merge branch 'master' into feature/popover-click-away
niuware Jun 12, 2020
b2de3cf
Merge branch 'feature/popover-click-away' of https://github.com/steur…
Jun 28, 2020
f55910f
Merge branch 'feature/popover-click-away' of https://github.com/steur…
Jun 28, 2020
135ee7a
Merge branch 'master' into feature/popover-click-away
Jun 28, 2020
85ce13f
Merge branch 'master' into feature/popover-click-away
niuware Oct 8, 2020
a83a04e
Merge branch 'master' into feature/popover-click-away
steurt Nov 8, 2020
f533194
Merge branch 'master' into feature/popover-click-away
steurt Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/MUIRichTextEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,7 @@ const MUIRichTextEditor: RefForwardingComponent<TMUIRichTextEditorRef, IMUIRichT
data={state.urlData}
anchor={state.anchorUrlPopover}
onConfirm={handleConfirmPrompt}
onCancel={dismissPopover}
isMedia={state.urlIsMedia}
/>
: null}
Expand Down
2 changes: 2 additions & 0 deletions src/components/UrlPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ interface IUrlPopoverStateProps extends WithStyles<typeof styles> {
data?: TUrlData
isMedia?: boolean
onConfirm: (isMedia?: boolean, ...args: any) => void
onCancel: () => void
}

const styles = ({ spacing }: Theme) => createStyles({
Expand Down Expand Up @@ -68,6 +69,7 @@ const UrlPopover: FunctionComponent<IUrlPopoverStateProps> = (props) => {
return (
<Popover
open={props.anchor !== undefined}
onClose={props.onCancel}
anchorEl={props.anchor}
anchorOrigin={{
vertical: "bottom",
Expand Down