feat: add guest nickname handling#33
Conversation
0a82768 to
d3213f8
Compare
ShGKme
left a comment
There was a problem hiding this comment.
Makes sense to fix both issues. But seems unrelated to sharing library, or do I get meaning of this library wrong?
Tough discussion. I think it fits tbh. We already have some public sharing handling here. So I think this is where it makes more sense :) |
d3213f8 to
8296eb5
Compare
Signed-off-by: skjnldsv <[email protected]>
8296eb5 to
3765948
Compare
|
Hm I am not that sure, as this library is more about files sharing (potentially we should add the Share model etc to this library). For me this part should probably be in the same library as |
|
(code looks fine tough) |
Our entire sharing backend allows any resources to be shared, not only file :) Nonetheless, I would also agree, I like the idea to have this on auth. |
|
Auth sounds even more fitting to me |
|
Let's gooo! The people have spoken! 🧑⚖️ |
Fix nextcloud/server#17147
Fix nextcloud-libraries/nextcloud-browser-storage#3