Sorbet linter#2514
Open
taq wants to merge 1 commit into
Open
Conversation
Member
Should it maybe then not get used by default (if installed)? Also it would be nice to have some tests with example output - please consider at least providing it here, I can look at adding the test then. |
Contributor
Author
|
Hey. Yes, being optional is a good idea. Ruby 3 will allow to use type checking, but not everybody will use that. |
Member
The raw ouput from some test/lint run would be enough - it does not need the input files, but would be mocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Sorbet linter. To make sure it will not conflict with the Rubocop linter result, is a good idea install rubocop-sorbet.