Remove option to include pybind11/eigen.h.

This was for partial backwards compatibility with ndarray's old Eigen interface, and is now being removed.
ndarray · TallJimbo · Jul 29, 2019 · Jul 29, 2019 · Jul 29, 2019 · Jul 29, 2019
commit 7ac22eb839fb6f3be98b45eab8b7357e947db9a6
diff --git a/.gitignore b/.gitignore
@@ -19,7 +19,6 @@ tests/ndarray
 tests/ndarray-eigen
 tests/ndarray-fft
 tests/swig_test_mod.py
-include/ndarray/buildOptions.h
 include/ndarray/Array.h
 include/ndarray/ArrayBaseN.h
 include/ndarray/ArrayRef.h

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -16,7 +16,6 @@ project(ndarray)
 # only executed if NDARRAY_TEST is enabled.
 option(NDARRAY_TEST "Enable tests?" ON)
 option(NDARRAY_EIGEN "Enable Eigen tests?" ON)
-option(NDARRAY_STDPYBIND11EIGEN "Enable standard pybind11 Eigen wrappers (requires Eigen > 3.2.5)?" OFF)
 option(NDARRAY_FFTW "Enable FFTW tests?" ON)
 option(NDARRAY_PYBIND11 "Enable Pybind11 tests?" OFF)
 

diff --git a/include/CMakeLists.txt b/include/CMakeLists.txt
@@ -36,9 +36,6 @@ foreach(FILENAME ${PREPROCESS_FILES2})
         )
 endforeach(FILENAME)
 
-# record certain build options
-configure_file(ndarray/buildOptions.h.in "${CMAKE_CURRENT_SOURCE_DIR}/ndarray/buildOptions.h")
-
 add_custom_target(preprocess_includes1 ALL DEPENDS ${PREPROCESS_FILES1})
 add_custom_target(preprocess_includes2 ALL DEPENDS ${PREPROCESS_FILES2})
 add_dependencies(preprocess_includes2 preprocess_includes1)
diff --git a/include/ndarray/buildOptions.h.in b/include/ndarray/buildOptions.h.in
diff --git a/include/ndarray/eigen_fwd.h b/include/ndarray/eigen_fwd.h
@@ -11,8 +11,6 @@
 #ifndef NDARRAY_eigen_fwd_h_INCLUDED
 #define NDARRAY_eigen_fwd_h_INCLUDED
 
-#include "ndarray/buildOptions.h"
-
 /**
  *  @file ndarray/eigen_fwd.h
  *  @brief Forward declarations for ndarray/eigen interface.

diff --git a/include/ndarray/pybind11.h b/include/ndarray/pybind11.h
@@ -44,14 +44,8 @@
 #include "pybind11.h"
 #include "pybind11/numpy.h"
 
-#include "ndarray/buildOptions.h"
-#ifdef NDARRAY_STDPYBIND11EIGEN
-#include "pybind11/eigen.h"
-#endif  // NDARRAY_STDPYBIND11EIGEN
-
 #include "ndarray.h"
 #include "ndarray/eigen.h"
-#include "ndarray/buildOptions.h"
 
 namespace ndarray {
 

diff --git a/tests/ndarray-eigen.cc b/tests/ndarray-eigen.cc
@@ -9,7 +9,6 @@
  * https://github.com/ndarray/ndarray
  */
 #include "ndarray/eigen.h"
-#include "ndarray/buildOptions.h"
 #include "Eigen/SVD"
 
 #define BOOST_TEST_DYN_LINK

diff --git a/tests/pybind11_test_mod.cc b/tests/pybind11_test_mod.cc
@@ -1,7 +1,6 @@
 #include "pybind11/pybind11.h"
 
 #include "ndarray/pybind11.h"
-#include "ndarray/buildOptions.h"
 
 namespace py = pybind11;
 using namespace py::literals;