Skip to content

Comments

Switch to Boost unit test headers#76

Merged
TallJimbo merged 6 commits intondarray:masterfrom
brianv0:boost_headers_test_variant
Jul 29, 2019
Merged

Switch to Boost unit test headers#76
TallJimbo merged 6 commits intondarray:masterfrom
brianv0:boost_headers_test_variant

Conversation

@brianv0
Copy link
Contributor

@brianv0 brianv0 commented Jul 18, 2019

This pull request is an attempt to switch to the header variant of unit test. This may help with linking issues in conda.

Issues [I think] I also ran into (that may already be known or might be issues on my part)

  • ndarray is not compatible with eigen 3.3.x
  • ndarray is not compatible with pybind11 2.3.x
  • conda-forge's compilers maybe uses an older glibc by default so -lrt was required in .travis.yml

@brianv0 brianv0 force-pushed the boost_headers_test_variant branch from 21176c0 to 01429f2 Compare July 18, 2019 15:47
@brianv0 brianv0 marked this pull request as ready for review July 18, 2019 21:48
@TallJimbo TallJimbo merged commit 78c703a into ndarray:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants