Conversation
Netlify deploy previewhttps://deploy-preview-47950--material-ui.netlify.app/ Bundle size report
|
|
It looks very nice 👌 Some issues I spotted:
|
| const { | ||
| disableAd = false, | ||
| disableToc = false, | ||
| container, |
There was a problem hiding this comment.
| container, | |
| container = 'narrow', |
?
| const { | ||
| disableAd = false, | ||
| disableToc = false, | ||
| container, |
There was a problem hiding this comment.
| container, | |
| container = 'narrow', |
Same?
| title: PropTypes.string, | ||
| }), | ||
| children: PropTypes.node.isRequired, | ||
| container: PropTypes.oneOf(['narrow', 'wide']), |
There was a problem hiding this comment.
I would recommend using a boolean prop if there are only two options.
|
@mnajdova @dav-is Thank you for the review 🙏
|
|
Maybe we need to also show the popover on focus and change the selected item when focus changes? Screencast.From.2026-03-12.09-53-57.webm |
|
Are we able to add the collapsed ToC when on other pages when the width is too small for the full ToC? I like having it on my veritcal desktop screen |
aarongarciah
left a comment
There was a problem hiding this comment.
Looking good!
-
I think it'd make sense to collapse the ToC only when there's not enough space. See this screenshot for example. Why hide it when there's room to display it?

-
The collapsed ToC accessibility is broken. The links have no label. When using a screen reader, there should be no difference between the collapsed and uncollapsed versions. See screenshots below.
The ToC popover can be treated as visual aid for sighted users (same mental model as Base UI Tooltips), so I think we could just hide it from assistive tech if the collapsed version labels are fixed.
|
Thanks for the review, Aaron 🙏
Hmm, that could also make sense 🤔 In that case, DX question - would you |
For context: we chatted about it and we decided to try option a |
|
How will the sponsors UI look when we have third sponsor? |
|
Update:
@mnajdova an idea of what I was thinking off when I changed the sponsors layout:
|
|
2 remarks:
|
|
Thanks, Jan 🙏
|
We want to support an infinite number of sponsors, but this is not going to support it. I'm also not sure about the reduced vertical space for scrolling the side nav on a 14" screen. So how about?
Side feedback: Are the lengths of the bars optimal?
I thought the length of a bar was supposed to encode the hx nature of them. At least, that's how Notion helps me skip h3 when I want to move to the next h2. |










Preview
In this PR
<MarkdownDocs />:wideLayout: increases the maximum width of the docs content toxl/1536px.collapseToc: replaces the current ToC with a minified version on ALL breakpoints where it is visible (ToC is hidden on tablet and mobile)Recording.2026-03-11.170933.mp4
The two props are independent, so technically the current ToC can be used with the wide docs or we can use the minified ToC with the narrow docs.
Open question
Do we want to change the current default behavior and enforce the minified ToC on smaller devices (at least lg and md)? Right now we hide the ToC under
1440pxwhich might not be a great UX 🤔