[app-bar] Fix optional chaining in joinVars function#47739
Merged
sai6855 merged 3 commits intomui:masterfrom Feb 10, 2026
Merged
[app-bar] Fix optional chaining in joinVars function#47739sai6855 merged 3 commits intomui:masterfrom
sai6855 merged 3 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-47739--material-ui.netlify.app/ Bundle size report
|
sai6855
commented
Feb 10, 2026
|
|
||
| // var2 is the fallback. | ||
| // Ex. var1: 'var(--a)', var2: 'var(--b)'; return: 'var(--a, var(--b))' | ||
| const joinVars = (var1, var2) => (var1 ? `${var1?.replace(')', '')}, ${var2})` : var2); |
Member
Author
There was a problem hiding this comment.
Optional chaining is not required here since var1 will always be truthy when var1.replace runs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the joinVars helper in AppBar to remove redundant optional chaining, ensuring the function consistently treats var1 as a string when it is present and avoids silently producing "undefined, ..." output.
Changes:
- Remove optional chaining from
var1?.replace(...)insidejoinVars. - Keep existing fallback behavior when
var1is falsy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZeeshanTamboli
approved these changes
Feb 10, 2026
ZeeshanTamboli
added
the
type: enhancement
ZeeshanTamboli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix optional chaining in joinVars function