Replace VCR cassettes with responses library for test mocking #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

the-muppet wants to merge 1 commit into mtgjson:master from the-muppet:test-fix

Contributor

the-muppet commented Dec 10, 2025

Summary

Replace VCR cassette-based HTTP mocking with the responses library for Scryfall API tests
Use static JSON fixtures validated against Pydantic schemas for deterministic, offline testing

Why

VCR cassettes are brittle and require re-recording when API responses change
Static fixtures with responses give explicit control over test data
Faster test execution without cassette I/O overhead
Easier to maintain and review test data as plain JSON files

Changes

Added responses library for request mocking
Created static fixture files for catalog and card data
Updated conftest.py with mock_scryfall_catalog fixture
Set assert_all_requests_are_fired=False to allow flexible endpoint mocking


          Replaces VCR with responses for Scryfall tests

909d8b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet