Skip to content

Comments

Allow for subclassing of dict#18

Closed
wmoss wants to merge 1 commit intomsgpack:masterfrom
wmoss:master
Closed

Allow for subclassing of dict#18
wmoss wants to merge 1 commit intomsgpack:masterfrom
wmoss:master

Conversation

@wmoss
Copy link

@wmoss wmoss commented Sep 21, 2012

...lassed (by OrderDict, for example)

@methane
Copy link
Member

methane commented Sep 22, 2012

I have committed support of dict subclass now.
Cython can use faster way to iterate over dict when it has dict type.
So I use PyDict_CheckExact for dict and PyDict_Check for subclasses.

Anyway, thank you for reporting.

@methane methane closed this Sep 22, 2012
@wmoss
Copy link
Author

wmoss commented Oct 2, 2012

Cool, thanks for fixing the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants