[cherry-pick] fix bigint on raspberry pi #6627
Conversation
this fixes an issue where base can be out of range on a raspberry pi.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @suetanvil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical issue affecting BigInt operations on Raspberry Pi devices. It incorporates a targeted fix that resolves an 'out of range' error encountered during BigInt initialization, ensuring proper functionality and stability for applications utilizing BigInts on this platform. This change is a cherry-pick of an existing solution to the stable branch.
Highlights
- BigInt Fix for Raspberry Pi: Corrected a type casting issue in
mrb_bint_new_strwithinsrc/vm.cby explicitly castings[1]to(int8_t), which resolves an "out of range" error when handling BigInts on Raspberry Pi devices.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses a portability issue on platforms where char is unsigned by default, such as ARM architectures (e.g., Raspberry Pi). The change ensures that the base for a BigInt literal, which can be negative to indicate a negative number, is correctly interpreted as a signed value. By casting the character holding the base to int8_t, the code now behaves consistently across different architectures, preventing potential misinterpretation of the base value. The fix is correct, well-targeted, and improves the portability of the mruby interpreter.
|
@suetanvil If it is wrong, please try changing it to the "stable" branch. |
|
I have changed it (I hope). Sorry about that. |
4 participants
this fixes an issue where base can be out of range on a raspberry pi.
(This pull request cherry-picks the referenced commit onto the stable branch as requested in #6625 )