This repository was archived by the owner on Nov 11, 2019. It is now read-only.
pulselistener: Avoid updating a secured revision#2124
Merged
Conversation
marco-c
reviewed
May 22, 2019
| logger.info('Published secure build as failing', build=str(build)) | ||
| # We cannot send any update on a Secured build | ||
| # as the bot has no edit access on it | ||
| logger.info('Secured revision, skipping.', build=build.target_phid) |
Collaborator
There was a problem hiding this comment.
So, what is the UI like on a secure revision? Does the build show as pending?
Contributor
Author
There was a problem hiding this comment.
I'm not sure, i think so...
Collaborator
There was a problem hiding this comment.
Mmmh, not great, we should figure out an alternative.
Collaborator
There was a problem hiding this comment.
Maybe let's talk about this in the next meeting with engflow.
marco-c
approved these changes
May 22, 2019
Collaborator
marco-c
left a comment
marco-c
left a comment
There was a problem hiding this comment.
LGTM for now to avoid the crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a crash on pulselistener when a revision is secured, the hook tries to update the revision... but it has no access to it !