This repository was archived by the owner on Nov 11, 2019. It is now read-only.
staticanalysis/bot: Check a path is in revision before publishing in before/after#2006
Merged
Conversation
marco-c
reviewed
Mar 29, 2019
| if settings.publication == Publication.BEFORE_AFTER: | ||
| # Simply use marker set on workflow | ||
| return self.is_new | ||
| # and check the revision contains the file |
Collaborator
There was a problem hiding this comment.
Can you expand the comment explaining that it is needed for Phab?
marco-c
approved these changes
Mar 29, 2019
added 2 commits
March 29, 2019 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2005.
Will certainly allow for a push to prod.